kaijchen commented on PR #3226: URL: https://github.com/apache/ozone/pull/3226#issuecomment-1125654077
I have decided not to add the `BucketLayout` in `OpenKeyBucket` proto in this patch for following reasons: 1. We are processing one kind of bucket at a time in `getExpiredOpenKeys`, the caller must know the `BucketLayout` it passed in. And all the expired keys got are in that kind of bucket. 2. Removing a field from proto is hard, it's better to add it in HDDS-4123 if we really need. I think adding `BucketLayout` in `OpenKeysDeleteRequest` is another feasible option. Please take another look @errose28, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
