sokui commented on code in PR #3185:
URL: https://github.com/apache/ozone/pull/3185#discussion_r872714535
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/HASecurityUtils.java:
##########
@@ -262,7 +262,7 @@ private static PKCS10CertificationRequest generateCSR(
client.getPrivateKey());
// Get host name.
- String hostname = scmAddress.getAddress().getHostName();
+ String hostname = scmAddress.getHostName();
Review Comment:
I cannot exactly remember. I think I got some cert issue when deploying to
k8s. But when I just tested this, it seems both of these correctly return the
hostname. I cannot remember now why I have this change. Are you OK to keep my
change, or you think I should revert it? Please let me know. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
