adoroszlai opened a new pull request, #3413: URL: https://github.com/apache/ozone/pull/3413
## What changes were proposed in this pull request? SCM during start sends `addSCM` request to its peers. It tries to exclude itself from the target list: https://github.com/apache/ozone/blob/40461504478182af509db7098d4e173011d27e5a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/HAUtils.java#L119-L121 but `removeSelfId` does not work. The bug is that it sets the generic `ozone.scm.nodes` property, leaving the SCM service-specific config key `ozone.scm.nodes.<service>` unchanged with 3 nodes. https://issues.apache.org/jira/browse/HDDS-6749 ## How was this patch tested? Added unit test. Also added log message to show list of peers the fail-over proxy is created with. From HA acceptance test: ``` scm2_1 | 2022-05-13 22:49:10,532 [main] INFO proxy.SCMBlockLocationFailoverProxyProvider: Created block location fail-over proxy with 2 nodes: [nodeId=scm1,nodeAddress=scm1/172.18.0.10:9863, nodeId=scm3,nodeAddress=scm3/172.18.0.6:9863] scm2_1 | 2022-05-13 22:49:36,580 [Listener at 0.0.0.0/9860] INFO proxy.SCMBlockLocationFailoverProxyProvider: Created block location fail-over proxy with 2 nodes: [nodeId=scm1,nodeAddress=scm1/172.18.0.10:9863, nodeId=scm3,nodeAddress=scm3/172.18.0.6:9863] ``` ``` scm3_1 | 2022-05-13 22:49:38,931 [main] INFO proxy.SCMBlockLocationFailoverProxyProvider: Created block location fail-over proxy with 2 nodes: [nodeId=scm2,nodeAddress=scm2/172.18.0.9:9863, nodeId=scm1,nodeAddress=scm1/172.18.0.10:9863] scm3_1 | 2022-05-13 22:49:46,296 [Listener at 0.0.0.0/9860] INFO proxy.SCMBlockLocationFailoverProxyProvider: Created block location fail-over proxy with 2 nodes: [nodeId=scm2,nodeAddress=scm2/172.18.0.9:9863, nodeId=scm1,nodeAddress=scm1/172.18.0.10:9863] ``` https://github.com/adoroszlai/hadoop-ozone/actions/runs/2322096338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
