smengcl commented on PR #3397: URL: https://github.com/apache/ozone/pull/3397#issuecomment-1128572967
> Thanks for the updates @smengcl. LGTM, but can we unit test this new code path? We can check for the exception thrown from the config check method with different valid/invalid config combinations. We can also directly invoke `OzoneManagerRatisUtils#createClientRequest`, `OzoneManagerRequestHandler#handleReadRequest`, and `OzoneManager#getS3VolumeContext` to check that requests are correctly blocked when the feature is disabled. Thanks @errose28 . I have added the new tests. Note that `OzoneManager#getS3VolumeContext` will not throw exception when Multi-Tenancy is disabled. Actually in this case, we won't be checking any MT tables at all. All requests will simply be redirected to `s3v` for backwards compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
