sodonnel commented on code in PR #3425:
URL: https://github.com/apache/ozone/pull/3425#discussion_r876337781


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManagerImpl.java:
##########
@@ -331,6 +341,10 @@ public void removeContainerReplica(final ContainerID cid,
       throws ContainerNotFoundException, ContainerReplicaNotFoundException {
     if (containerExist(cid)) {
       containerStateManager.removeContainerReplica(cid, replica);
+      // Remove any pending delete replication operations for the deleted
+      // replica.

Review Comment:
   Yea, when the new replicas arrive, they will be reported via ICR / FCR as 
usual, and then we complete them. It should work exactly the same as for Ratis 
replicas.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to