rakeshadr commented on code in PR #3427:
URL: https://github.com/apache/ozone/pull/3427#discussion_r876900149
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OMLockMetrics.java:
##########
@@ -203,5 +203,7 @@ public void getMetrics(MetricsCollector collector, boolean
all) {
MetricsRecordBuilder builder = collector.addRecord(SOURCE_NAME);
readLockHeldTimeMsStat.snapshot(builder, all);
readLockWaitingTimeMsStat.snapshot(builder, all);
+ writeLockHeldTimeMsStat.snapshot(builder, all);
+ writeLockWaitingTimeMsStat.snapshot(builder, all);
Review Comment:
Can we add a test case?. Probably you can refer: TestReplicationSupervisor
```
MetricsCollectorImpl metricsCollector = new MetricsCollectorImpl();
metrics.getMetrics(metricsCollector, true);
Assert.assertEquals(1, metricsCollector.getRecords().size());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
