smengcl commented on code in PR #3381:
URL: https://github.com/apache/ozone/pull/3381#discussion_r877112958
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/tenant/TenantGetSecretHandler.java:
##########
@@ -57,14 +53,11 @@ protected void execute(OzoneClient client, OzoneAddress
address)
try {
final S3SecretValue accessIdSecretKeyPair =
objectStore.getS3Secret(accessId, false);
- if (export) {
- out().println("export AWS_ACCESS_KEY_ID='" +
- accessIdSecretKeyPair.getAwsAccessKey() + "'");
- out().println("export AWS_SECRET_ACCESS_KEY='" +
- accessIdSecretKeyPair.getAwsSecret() + "'");
- } else {
- out().println(accessIdSecretKeyPair);
- }
+ // Always print export format
+ out().println("export AWS_ACCESS_KEY_ID='" +
+ accessIdSecretKeyPair.getAwsAccessKey() + "'");
+ out().println("export AWS_SECRET_ACCESS_KEY='" +
+ accessIdSecretKeyPair.getAwsSecret() + "'");
} catch (OMException omEx) {
Review Comment:
Good point. Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
