ChenSammi commented on code in PR #3350:
URL: https://github.com/apache/ozone/pull/3350#discussion_r877842498
##########
hadoop-hdds/common/src/main/resources/network-topology-default.yaml:
##########
@@ -30,32 +30,26 @@ prefix: /
type: ROOT
# Layer name
-defaultName: root
+defaultName: datacenter
# Sub layer
# The sub layer property defines as a list which can reflect a node tree,
though
# in schema template it always has only one child.
sublayer:
-
cost: 1
- prefix: dc
- defaultName: datacenter
+ prefix: rack
+ defaultName: rack
type: INNER_NODE
sublayer:
- -
- cost: 1
- prefix: rack
- defaultName: rack
- type: INNER_NODE
- sublayer:
+ -
+ cost: 1
+ prefix: ng
+ defaultName: nodegroup
Review Comment:
There is no nodegroup in default topology. We can remove this layer.
Could you add a unit test in TestYamlSchemaLoader.java? load this default
topology configuration file, and check there is 3 level NodeSchema in
NodeSchemaManager?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
