JyotinderSingh commented on code in PR #3411:
URL: https://github.com/apache/ozone/pull/3411#discussion_r881580983
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/validation/RequestValidations.java:
##########
@@ -97,7 +97,7 @@ public OMResponse validateResponse(OMRequest request,
OMResponse response)
m.getName(), m.getDeclaringClass().getPackage().getName(),
m.getDeclaringClass().getSimpleName());
validatedResponse =
- (OMResponse) m.invoke(null, request, response, context);
+ (OMResponse) m.invoke(null, request, validatedResponse, context);
Review Comment:
We want to use the `validatedResponse` object across all the
RequestValidators - otherwise, the validated responses from these validators
would all end up being ignored - and only the validated response from whatever
the last validator that was run would be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
