guihecheng commented on PR #3474: URL: https://github.com/apache/ozone/pull/3474#issuecomment-1144887548
LGTM+1 Verified basic functionality manually: 1. deploy an old cluster without this feature 2. write dataset1 with ockg 3. upgrade package with this feature 4. check finalization status 5. verify dataset1 with ockv 6. write dataset2 with ockg 7. check container schemaVersion=v2 by hand 8. do finalizeupgrade 9. check finalization status 10. write dataset3 with ockg 11. check container schemaVersion=v2 by hand 12. restart cluster with the option `hdds.datanode.container.schema.v3.enabled` = true 13. write dataset4 with ockg 14. check container schemaVersion=v3 by hand(here I close the existing OPEN containers by hand) 15. verify previous data with ockv 16. finally do grep `ERROR` logs, nothing found So I think this merge PR is good from my side, Thanks @ChenSammi ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
