rakeshadr commented on code in PR #3480:
URL: https://github.com/apache/ozone/pull/3480#discussion_r888573067
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -101,7 +101,8 @@ enum Type {
RevokeS3Secret = 93;
- PurgeDirectories = 94;
+ PurgePaths = 94; // [deprecated=true]
Review Comment:
Any specific reason for commented out the statement. Should it be
`PurgePaths = 94 [deprecated=true];`
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -297,7 +299,8 @@ message OMResponse {
optional ListTrashResponse listTrashResponse =
91;
optional RecoverTrashResponse RecoverTrashResponse =
92;
- optional PurgeDirectoriesResponse purgeDirectoriesResponse =
93;
+ optional PurgePathsResponse purgePathsResponse =
93; // [deprecated = true]
Review Comment:
Here again the same as above. Should it be without comment line ?
I could see everywhere the deprecated line is commented out.
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -201,7 +202,8 @@ message OMRequest {
optional RevokeS3SecretRequest RevokeS3SecretRequest =
93;
- optional PurgeDirectoriesRequest purgeDirectoriesRequest =
94;
+ optional PurgePathsRequest purgePathsRequest =
94; // [deprecated = true]
Review Comment:
Here again the same as above. Should it be without comment line ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
