sodonnel commented on code in PR #3482:
URL: https://github.com/apache/ozone/pull/3482#discussion_r893329852
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/LegacyReplicationManager.java:
##########
@@ -1450,9 +1537,8 @@ private void sendReplicateCommand(final ContainerInfo
container,
final ContainerID id = container.containerID();
final ReplicateContainerCommand replicateCommand =
new ReplicateContainerCommand(id.getId(), sources);
- inflightReplication.computeIfAbsent(id, k -> new ArrayList<>());
sendAndTrackDatanodeCommand(datanode, replicateCommand,
- action -> inflightReplication.get(id).add(action));
+ action -> inflightReplication.add(id, action));
Review Comment:
I guess we should probably check the return status here, and increment some
metric if we are skipping the replication for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
