umamaheswararao commented on code in PR #3498:
URL: https://github.com/apache/ozone/pull/3498#discussion_r894756542
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/client/ReplicationConfigValidator.java:
##########
@@ -50,10 +50,11 @@ public void init() {
public ReplicationConfig validate(ReplicationConfig replicationConfig) {
if (validationRegexp != null) {
- if (!validationRegexp.matcher(replicationConfig.toString()).matches()) {
+ if (!validationRegexp.matcher(
+ replicationConfig.configFormat()).matches()) {
throw new IllegalArgumentException("Invalid replication config " +
- replicationConfig + ". Replication config should match the "
- + validationPattern + " pattern.");
+ replicationConfig.configFormat() + ". Replication config " +
+ "should match the " + validationPattern + " pattern.");
Review Comment:
I am worried on displaying this validationPatten in log. Are we allowing
just EC-3-2 ? without chunk size in string? ( If not, we will get another bug
about this log saying " this log is confusing" :-) )
Probably we can allow in ECReplicationConfig and just take 1024K as default
for chunkSize?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
