adoroszlai opened a new pull request, #3518: URL: https://github.com/apache/ozone/pull/3518
## What changes were proposed in this pull request? `AllocateBlock` request may be unable to allocate as many blocks as requested, but it still reports it in audit log as success if there are no exceptions. This PR adds the actual number of blocks allocated to the log message, and logs it as FAILURE instead of SUCCESS if fewer blocks were allocated than requested. https://issues.apache.org/jira/browse/HDDS-6847 ## How was this patch tested? Temporarily added integration test to create key with RS(6,3) EC replication in 5-node cluster: ``` ERROR block.BlockManagerImpl (BlockManagerImpl.java:allocateBlock(184)) - Unable to allocate a block for the size: 4194304, replicationConfig: EC/ECReplicationConfig{data=6, parity=3, ecChunkSize=1048576, codec=rs} ERROR SCMAudit ... | op=ALLOCATE_BLOCK {replication=EC/ECReplicationConfig{data=6, parity=3, ecChunkSize=1048576, codec=rs}, owner=om1, size=4194304, num=1, allocated=0} | ret=FAILURE INTERNAL_ERROR org.apache.hadoop.ozone.om.exceptions.OMException: Allocated 0 blocks. Requested 1 blocks ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
