guihecheng commented on PR #3523:
URL: https://github.com/apache/ozone/pull/3523#issuecomment-1157649681
> I think this change looks good. I think it will fix the issue.
>
> A test to reproduce the problem is likely too difficult, but I'd like to
see a test that executes the new refresh wrapper.
>
> Do you think we could create a protected method called something like:
>
> ```
> Function<BlockID, Pipeline> ecPipelineRefreshFunction(BlockId blockID, int
replicaIndex, Function<BlockID, Pipeline> refreshFunction) {
> ...
> }
> ```
>
> Then we can create a simple unit test that creates a simple refresh
function that returns an hardcoded ECPipeline object, that is used by our new
wrapper, and validate the correct node is selected based on the index?
Oh, that's a good idea to cover this small function with test, Thanks, I'll
update soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
