sokui commented on code in PR #3186:
URL: https://github.com/apache/ozone/pull/3186#discussion_r900523615


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/WritableRatisContainerProvider.java:
##########
@@ -123,8 +119,25 @@ public ContainerInfo getContainer(final long size,
 
         } catch (SCMException se) {
           LOG.warn("Pipeline creation failed for repConfig {} " +
-              "Datanodes may be used up.", repConfig, se);
-          break;
+              "Datanodes may be used up. Try to see if any pipeline is in " +
+                  "ALLOCATED state, and then will wait for it to be OPEN",
+                  repConfig, se);
+          List<Pipeline> allocatedPipelines = findPipelinesByState(repConfig,

Review Comment:
   I usually do not use sleep() in unit tests, because it may cause the unit 
test unreliable. But for this test, we have no other better way to do it, and 
the sleep() here should not make the test case unstable. Let me include your 
commit. Thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to