umamaheswararao commented on code in PR #3522:
URL: https://github.com/apache/ozone/pull/3522#discussion_r901923356
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java:
##########
@@ -280,7 +280,13 @@ public ContainerCommandResponseProto sendCommand(
// Re-interrupt the thread while catching InterruptedException
Thread.currentThread().interrupt();
} catch (ExecutionException e) {
- LOG.error("Failed to execute command {}", processForDebug(request), e);
+ String message = "Failed to execute command {}.";
+ if (LOG.isDebugEnabled()) {
+ LOG.debug(message, processForDebug(request), e);
+ } else {
Review Comment:
Nit: You need to give space before "Exception Class".
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamProxy.java:
##########
@@ -165,8 +165,15 @@ public synchronized int read(ByteBuffer buf) throws
IOException {
throw e;
}
if (e instanceof BadDataLocationException) {
- LOG.warn("Failing over to reconstruction read due to an error in " +
- "ECBlockReader", e);
+ String message = "Failing over to reconstruction read due" +
+ " to an error in ECBlockReader.";
+ if(LOG.isDebugEnabled()) {
+ LOG.debug(message, e);
+ } else {
Review Comment:
Nit: Give space after {}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
