[
https://issues.apache.org/jira/browse/HDDS-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siyao Meng updated HDDS-6930:
-----------------------------
Description:
[~aswinshakil] and I noticed that we SCM is shutdown normally it prints out the
ERROR log:
{code}
2022-06-21 20:37:52,246 ERROR
org.apache.hadoop.hdds.scm.server.StorageContainerManager: Terminating with
exit status 1: scm statemachine is closed by ratis, terminate SCM
{code}
1. This can be misleading as it shouldn't print ERROR if SCM is being shut down
*normally*;
2. And the [exit code should be
0|https://github.com/apache/ozone/blob/349f47d8a382f648b2fd947519ab7bdbb989edcf/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java#L1629]
if shutdown is successful. >0 values conventionally indicates errors.
was:
[~aswinshakil] and I noticed that we SCM is shutdown normally it prints out the
ERROR log:
{code}
2022-06-21 20:37:52,246 ERROR
org.apache.hadoop.hdds.scm.server.StorageContainerManager: Terminating with
exit status 1: scm statemachine is closed by ratis, terminate SCM
{code}
1. This can be misleading as it shouldn't print ERROR if SCM is being shut down
*normally*;
2. And the [exit code should be
0|https://github.com/apache/ozone/blob/349f47d8a382f648b2fd947519ab7bdbb989edcf/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java#L1629]
if shutdown ended successfully. >0 values conventionally indicates errors.
> SCM should not print ERROR and exit with code 1 on successful shutdown
> ----------------------------------------------------------------------
>
> Key: HDDS-6930
> URL: https://issues.apache.org/jira/browse/HDDS-6930
> Project: Apache Ozone
> Issue Type: Bug
> Reporter: Siyao Meng
> Priority: Major
>
> [~aswinshakil] and I noticed that we SCM is shutdown normally it prints out
> the ERROR log:
> {code}
> 2022-06-21 20:37:52,246 ERROR
> org.apache.hadoop.hdds.scm.server.StorageContainerManager: Terminating with
> exit status 1: scm statemachine is closed by ratis, terminate SCM
> {code}
> 1. This can be misleading as it shouldn't print ERROR if SCM is being shut
> down *normally*;
> 2. And the [exit code should be
> 0|https://github.com/apache/ozone/blob/349f47d8a382f648b2fd947519ab7bdbb989edcf/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java#L1629]
> if shutdown is successful. >0 values conventionally indicates errors.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
