errose28 commented on code in PR #3508:
URL: https://github.com/apache/ozone/pull/3508#discussion_r903139108
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java:
##########
@@ -135,7 +141,9 @@ public OMResponse submitRequest(RpcController controller,
OMRequest request) throws ServiceException {
OMRequest validatedRequest;
try {
- validatedRequest = requestValidations.validateRequest(request);
+ OMRequest requestWithBucketId = associateBucketIdWithRequest(request);
Review Comment:
Can we add the bucket ID to the request in the preprocess validator for each
request? It may make this particular PR larger, but since every request
pre-processor is already there in the code, it will be less invasive overall.
The purpose of the request validators is to remove large switch blocks like
what is in `associateBucketIdWithRequest` so we can group logic on a
per-request basis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
