duongnguyen0 commented on code in PR #3531:
URL: https://github.com/apache/ozone/pull/3531#discussion_r904445419
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/EndpointBase.java:
##########
@@ -308,4 +308,14 @@ protected Map<String, String> getAuditParameters() {
}
return res;
}
+
+ protected void auditWriteFailure(AuditAction action, Throwable ex) {
+ AUDIT.logWriteFailure(
+ buildAuditMessageForFailure(action, getAuditParameters(), ex));
+ }
+
+ protected void auditReadFailure(AuditAction action, Exception ex) {
+ AUDIT.logReadFailure(
+ buildAuditMessageForFailure(action, getAuditParameters(), ex));
+ }
Review Comment:
Yeah, I intended to keep the scope of this PR for the error logging. But
actually we can extend it a little bit to success audits to make the code
consistent. Good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
