umamaheswararao commented on PR #3539: URL: https://github.com/apache/ozone/pull/3539#issuecomment-1164425249
Changes looks good to me. I just realized, SCMCommand actually defined with token. Do you think we can actually send the container token from SCM itself and use that? 1d is the default expiry time. Just a thought. But current approach also should fine. Even though we are creating containers from DN, ideally they are more responsible by SCM and blocks are responsible for DN. This can be separate JIRA also if that make sense to send the token over wire. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
