adoroszlai commented on code in PR #3552:
URL: https://github.com/apache/ozone/pull/3552#discussion_r907091355
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java:
##########
@@ -244,6 +244,8 @@ public Response put(@PathParam("bucket") String bucketName,
try {
if (aclMarker != null) {
s3GAction = S3GAction.PUT_ACL;
+ AUDIT.logWriteSuccess(
+ buildAuditMessageForSuccess(s3GAction, getAuditParameters()));
Review Comment:
`logWriteSuccess` should be moved to the normal, non-exception code path in
`putAcl`. Otherwise we might end up logging both success and failure for
failed requests.
https://github.com/apache/ozone/blob/6354406b4a06a7d13c1bde19c95c268dd6debfbd/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java#L579-L580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
