adoroszlai commented on code in PR #3545:
URL: https://github.com/apache/ozone/pull/3545#discussion_r907271078
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ContainerReplicaOp.java:
##########
@@ -36,6 +36,12 @@ public enum PendingOpType {
private int replicaIndex;
private long scheduledEpochMillis;
+ public static ContainerReplicaOp create(PendingOpType opType,
+ DatanodeDetails target, int replicaIndex) {
+ return new ContainerReplicaOp(opType, target, replicaIndex,
+ System.currentTimeMillis());
+ }
Review Comment:
Nit: as far as I see this is only for test (`TestECContainerHealthCheck`),
wouldn't it be better to define as helper in that class (or
`ReplicationTestUtil`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
