kerneltime commented on code in PR #3562:
URL: https://github.com/apache/ozone/pull/3562#discussion_r908588274
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerMetrics.java:
##########
@@ -121,6 +122,42 @@ public void
incrementNumContainerMovesCompletedInLatestIteration(
this.numContainerMovesCompletedInLatestIteration.incr(valueToAdd);
}
+ public void incrementCurrentIterationContainerMoveMetric(
+ MoveResult result,
+ long valueToAdd) {
+ if (result == null) {
+ return;
+ }
+ switch (result) {
+ case COMPLETED:
+ this.numContainerMovesCompletedInLatestIteration.incr(valueToAdd);
+ break;
+ case REPLICATION_FAIL_TIME_OUT:
+ this.numContainerMovesTimeoutInLatestIteration.incr(valueToAdd);
+ break;
+ // TODO: Add metrics for other errors that need to be tracked.
+ case FAIL_NOT_RUNNING:
+ case REPLICATION_FAIL_INFLIGHT_REPLICATION:
+ case FAIL_NOT_LEADER:
+ case REPLICATION_FAIL_NOT_EXIST_IN_SOURCE:
+ case REPLICATION_FAIL_EXIST_IN_TARGET:
+ case REPLICATION_FAIL_CONTAINER_NOT_CLOSED:
+ case REPLICATION_FAIL_INFLIGHT_DELETION:
+ case REPLICATION_FAIL_NODE_NOT_IN_SERVICE:
+ case DELETION_FAIL_NODE_NOT_IN_SERVICE:
+ case REPLICATION_FAIL_NODE_UNHEALTHY:
+ case DELETION_FAIL_TIME_OUT:
Review Comment:
Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
