sodonnel commented on code in PR #3542:
URL: https://github.com/apache/ozone/pull/3542#discussion_r908895201
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ECContainerReplicaCount.java:
##########
@@ -127,6 +143,21 @@ public Set<Integer> decommissioningIndexes() {
return decommissionIndexes.keySet();
}
+ /**
+ * Get a set containing all decommissioning only indexes, or an empty set if
+ * none are decommissioning.
+ * @return Set of indexes in decommission only.
+ */
+ public Set<Integer> decommissioningOnlyIndexes() {
Review Comment:
Please try to add a simply test for this, and if we change it to have an
`includePendingAdd` flag, then test both scenarios. It may fit in as part of
another test with decommission making it just one or two additional lines.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ECContainerReplicaCount.java:
##########
@@ -127,6 +143,21 @@ public Set<Integer> decommissioningIndexes() {
return decommissionIndexes.keySet();
}
+ /**
+ * Get a set containing all decommissioning only indexes, or an empty set if
+ * none are decommissioning.
+ * @return Set of indexes in decommission only.
+ */
+ public Set<Integer> decommissioningOnlyIndexes() {
Review Comment:
Please try to add a simple test for this, and if we change it to have an
`includePendingAdd` flag, then test both scenarios. It may fit in as part of
another test with decommission making it just one or two additional lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
