sodonnel commented on code in PR #3573:
URL: https://github.com/apache/ozone/pull/3573#discussion_r911791756
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java:
##########
@@ -493,6 +498,15 @@ public boolean
isContainerReplicatingOrDeleting(ContainerID containerID) {
.isContainerReplicatingOrDeleting(containerID);
}
+ private ECContainerReplicaCount getECContainerReplicaCount(
+ ContainerInfo containerInfo) throws ContainerNotFoundException {
+ Set<ContainerReplica> replicas = containerManager.getContainerReplicas(
+ containerInfo.containerID());
+ List<ContainerReplicaOp> pendingOps =
+ containerReplicaPendingOps.getPendingOps(containerInfo.containerID());
+ return new ECContainerReplicaCount(containerInfo, replicas, pendingOps, 0);
Review Comment:
The zero at the end of the parameters is definitely not correct, but I don't
know yet what is the correct value to put here.
Could you add a TODO - define maintenance redundancy for EC (HDDS-6975) here?
We will need to fix this in a couple of places I think (not related to this
PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
