umamaheswararao commented on code in PR #3574:
URL: https://github.com/apache/ozone/pull/3574#discussion_r912402873
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ContainerHealthResult.java:
##########
@@ -77,10 +77,24 @@ public static class HealthyResult extends
ContainerHealthResult {
public static class UnderReplicatedHealthResult
extends ContainerHealthResult {
+ // For under replicated containers, the best remaining redundancy we can
+ // have is 3 for EC-10-4, 2 for EC-6-3, 1 for EC-3-2 and 2 for Ratis.
+ // A container which is under-replicated due to decommission will have one
+ // more, ie 4, 3, 2, 3 respectively. Ideally we want to sort decommission
+ // only under-replication after all other under-replicated containers.
+ // It may also make sense to allow under-replicated containers a chance to
+ // retry once before processing the decommission only under replication.
+ // Therefore we should adjust the weighted remaining redundancy of
+ // decommission only under-replicated containers to a floor of 5 so they
+ // sort after an under-replicated container with 3 remaining replicas (
+ // EC-10-4) and plus one retry.
+ private static final int DECOMMISSION_REDUNDANCY = 5;
Review Comment:
I am not sure we should block decom tasks. Decommision tasks (replicate
commands are lighter weight compared to reconstruction tasks). If cluster has
too manay reconstruction tasks ( may be due to rack down or so), decommission
will take very long time may be. I just looked at HDFS, looks we there is no
separate queue for decom. Probably let's move ahead with the current plan and
revisit based on how this is going with decom in practice. I am wondering there
may be complaints on decom taking longer time in practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
