smengcl commented on code in PR #3578:
URL: https://github.com/apache/ozone/pull/3578#discussion_r912577834
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/s3/security/TestS3GetSecretRequest.java:
##########
@@ -378,7 +377,7 @@ public void testGetSecretWithTenant() throws IOException {
new OMTenantAssignUserAccessIdRequest(
new OMTenantAssignUserAccessIdRequest(
assignUserToTenantRequest(TENANT_ID,
- USER_BOB_SHORT, ACCESS_ID_BOB)
Review Comment:
e.g. when we run tenant assign user CLI
([doc](https://ci-hadoop.apache.org/view/Hadoop%20Ozone/job/ozone-doc-master/lastSuccessfulBuild/artifact/hadoop-hdds/docs/public/feature/s3-tenant-commands.html#:~:text=Assign%20a%20user%20to%20a%20tenant)):
```bash
ozone tenant user assign testuser --tenant=tenantone
```
`testuser` is the `userPrincipal` in
[handler](https://github.com/apache/ozone/blob/f0b30130911f4d7bacbe711ce51be798f8d8ba80/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/tenant/TenantAssignUserAccessIdHandler.java#L70),
and is passed to OM as
[`username`](https://github.com/apache/ozone/blob/f3dc1580c5dfd56634120c0863f5c297ec78842e/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java#L1051-L1056).
The point is `userPrincipal` input here is supposed to be a short name, not a
full principal.
This is intentionally different from the legacy
[`GetS3SecretHandler`](https://github.com/apache/ozone/blob/19116fe1f14a779505147bf5687dbd6239dbd800/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/s3/GetS3SecretHandler.java#L55)
where the input is full principal **by default**, which doesn't make sense in
the first place IMO (because Kerberos principal can contain HOST making it
non-portable) but we are stuck with it for compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
