umamaheswararao commented on code in PR #3585:
URL: https://github.com/apache/ozone/pull/3585#discussion_r917163949
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerReader.java:
##########
@@ -207,6 +210,14 @@ public void verifyAndFixupContainerData(ContainerData
containerData)
KeyValueContainerUtil.parseKVContainerData(kvContainerData, config);
KeyValueContainer kvContainer = new KeyValueContainer(kvContainerData,
config);
+ if (kvContainer.getContainerState() == RECOVERING) {
+ if (shouldDeleteRecovering) {
+ kvContainer.delete();
Review Comment:
Nit: Typo: delete --> Delete
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/ozoneimpl/TestContainerReader.java:
##########
@@ -217,7 +217,7 @@ private List<Long> addBlocks(KeyValueContainer
keyValueContainer,
@Test
public void testContainerReader() throws Exception {
Review Comment:
How about we simply add a test which should simply create Recovering
container and restart the DN and check?
Refer: TestContainerCommandsEC for creating recovering containers.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerReader.java:
##########
@@ -207,6 +210,14 @@ public void verifyAndFixupContainerData(ContainerData
containerData)
KeyValueContainerUtil.parseKVContainerData(kvContainerData, config);
KeyValueContainer kvContainer = new KeyValueContainer(kvContainerData,
config);
+ if (kvContainer.getContainerState() == RECOVERING) {
+ if (shouldDeleteRecovering) {
+ kvContainer.delete();
Review Comment:
Also I assume this delete will take care of cleaning the rocksDB entries as
well.
CC: @guihecheng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
