errose28 commented on code in PR #3534:
URL: https://github.com/apache/ozone/pull/3534#discussion_r918418536


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/upgrade/BasicUpgradeFinalizer.java:
##########
@@ -85,14 +87,20 @@ public StatusAndMessages finalize(String upgradeClientID, T 
service)
     StatusAndMessages response = initFinalize(upgradeClientID, service);

Review Comment:
   Yes init should be in the lock for the case you described. I will refactor 
this block.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to