kerneltime commented on code in PR #3580: URL: https://github.com/apache/ozone/pull/3580#discussion_r918420601
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/BlockDeletingServiceMetrics.java: ########## @@ -0,0 +1,102 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.container.common.helpers; + +import org.apache.hadoop.metrics2.MetricsSystem; +import org.apache.hadoop.metrics2.annotation.Metric; +import org.apache.hadoop.metrics2.annotation.Metrics; +import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem; +import org.apache.hadoop.metrics2.lib.MutableCounterLong; +import org.apache.hadoop.ozone.container.keyvalue.statemachine.background.BlockDeletingService; + +/** + * Metrics related to Block Deleting Service running on Datanode. + */ +@Metrics(name = "BlockDeletingService Metrics", about = "Metrics related to " + + "background block deleting service on Datanode", context = "dfs") +public final class BlockDeletingServiceMetrics { + + private static BlockDeletingServiceMetrics instance; + public static final String SOURCE_NAME = + BlockDeletingService.class.getSimpleName(); + + @Metric(about = "The number of success delete block counts.") + private MutableCounterLong successCount; + + @Metric(about = "The number of success deleted block bytes.") + private MutableCounterLong successBytes; + + @Metric(about = "The number of failure delete block counts.") Review Comment: ```suggestion @Metric(about = "The number of failed delete blocks.") ``` ########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/BlockDeletingServiceMetrics.java: ########## @@ -0,0 +1,102 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.container.common.helpers; + +import org.apache.hadoop.metrics2.MetricsSystem; +import org.apache.hadoop.metrics2.annotation.Metric; +import org.apache.hadoop.metrics2.annotation.Metrics; +import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem; +import org.apache.hadoop.metrics2.lib.MutableCounterLong; +import org.apache.hadoop.ozone.container.keyvalue.statemachine.background.BlockDeletingService; + +/** + * Metrics related to Block Deleting Service running on Datanode. + */ +@Metrics(name = "BlockDeletingService Metrics", about = "Metrics related to " + + "background block deleting service on Datanode", context = "dfs") +public final class BlockDeletingServiceMetrics { + + private static BlockDeletingServiceMetrics instance; + public static final String SOURCE_NAME = + BlockDeletingService.class.getSimpleName(); + + @Metric(about = "The number of success delete block counts.") + private MutableCounterLong successCount; + + @Metric(about = "The number of success deleted block bytes.") Review Comment: ```suggestion @Metric(about = "The total bytes for blocks successfully deleted.") ``` ########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/BlockDeletingServiceMetrics.java: ########## @@ -0,0 +1,102 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.container.common.helpers; + +import org.apache.hadoop.metrics2.MetricsSystem; +import org.apache.hadoop.metrics2.annotation.Metric; +import org.apache.hadoop.metrics2.annotation.Metrics; +import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem; +import org.apache.hadoop.metrics2.lib.MutableCounterLong; +import org.apache.hadoop.ozone.container.keyvalue.statemachine.background.BlockDeletingService; + +/** + * Metrics related to Block Deleting Service running on Datanode. + */ +@Metrics(name = "BlockDeletingService Metrics", about = "Metrics related to " + + "background block deleting service on Datanode", context = "dfs") +public final class BlockDeletingServiceMetrics { + + private static BlockDeletingServiceMetrics instance; + public static final String SOURCE_NAME = + BlockDeletingService.class.getSimpleName(); + + @Metric(about = "The number of success delete block counts.") Review Comment: ```suggestion @Metric(about = "The number of successful delete blocks") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
