kerneltime commented on code in PR #3576:
URL: https://github.com/apache/ozone/pull/3576#discussion_r919453501
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -3081,6 +3083,53 @@ public ServiceInfoEx getServiceInfo() throws IOException
{
return new ServiceInfoEx(getServiceList(), caCertPem, caCertPemList);
}
+ @Override
+ public boolean triggerRangerBGSync(boolean noWait) throws IOException {
+
+ // OM should be leader and ready.
+ // This check should always pass if called from a client since there
+ // is a leader check somewhere before entering this method.
+ if (!isLeaderReady()) {
+ // And even if we could allow followers to trigger sync, checkLeader()
+ // calls inside the sync would quit the sync anyway.
+ throw new OMException("OM is not leader or not ready", INVALID_REQUEST);
+ }
+
+ final UserGroupInformation ugi = getRemoteUser();
+ // Check Ozone admin privilege
+ if (!isAdmin(ugi)) {
+ throw new OMException("Only Ozone admins are allowed to trigger "
+ + "Ranger background sync manually", PERMISSION_DENIED);
+ }
+
+ // Check if MT manager is inited
+ final OMMultiTenantManager mtManager = getMultiTenantManager();
+ if (mtManager == null) {
+ throw new OMException("S3 Multi-Tenancy is not enabled",
+ FEATURE_NOT_ENABLED);
+ }
+
+ // Check if Ranger BG sync task is inited
+ final OMRangerBGSyncService bgSync = mtManager.getOMRangerBGSyncService();
+ if (bgSync == null) {
+ throw new OMException("Background sync task is not initialized",
+ FEATURE_NOT_ENABLED);
+ }
+
+ // Trigger Ranger BG Sync
+ if (noWait) {
+ final Thread t = new Thread(bgSync::triggerRangerSyncOnce);
+ t.start();
+ LOG.info("User '{}' manually triggered Multi-Tenancy Ranger Sync "
+ + "in a new thread, tid={}", ugi, t.getId());
+ return true;
+ } else {
Review Comment:
Minor Nit: No else needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
