smengcl commented on PR #3603: URL: https://github.com/apache/ozone/pull/3603#issuecomment-1186908286
Thanks @DaveTeng0 for the patch. The CI `dependency` job is failing and looks related: https://github.com/apache/ozone/runs/7366664984 So it looks like `ranger-intg` 2.3.0 [introduced](https://github.com/apache/ranger/commit/997168a6f7521e15a98c78db117a33a3cf0d8383) a new dependency `jcl-over-slf4j.jar`. You could either: 1) follow the instructions in the job log and add it to the `jar-report.txt`; or 2) exclude this transitive dependency if it is unnecessary for `RangerClient` (which is what we use right now for S3 Multi-Tenancy feature) to function properly. e.g. https://github.com/apache/ozone/pull/3408/files#diff-9b97a58fd4c3b119bd214f9f27495be6556634fe83c3287dc1dec70cb209423cR159-R184 We might want to try approach (2) first as `jcl-over-slf4j` seem to have contaminated Ozone's classpath and is breaking this UT (unit test) utility method (not sure if this is the only broken method but is worrying): https://github.com/apache/ozone/runs/7366517427 ``` Error: org.apache.hadoop.ozone.om.request.volume.TestOMVolumeSetQuotaRequest.testValidateAndUpdateCacheWithQuota Time elapsed: 0.24 s <<< ERROR! java.lang.ClassCastException: org.apache.commons.logging.impl.SLF4JLocationAwareLog cannot be cast to org.apache.commons.logging.impl.Log4JLogger at org.apache.ozone.test.GenericTestUtils$LogCapturer.captureLogs(GenericTestUtils.java:256) at org.apache.hadoop.ozone.om.request.volume.TestOMVolumeSetQuotaRequest.testValidateAndUpdateCacheWithQuota(TestOMVolumeSetQuotaRequest.java:189) ``` As long as the CI passes after the new dependency exclusion we should be good (`TestMultiTenantAccessController` verifies if `RangerClient` works properly). Otherwise we would try to fix the UT method `GenericTestUtils$LogCapturer.captureLogs` and use (1) -- though again not sure if there would be other impacts, we'd have to see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
