sadanand48 commented on code in PR #3520:
URL: https://github.com/apache/ozone/pull/3520#discussion_r924121814
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java:
##########
@@ -789,4 +796,28 @@ public static String
getOMAddressListPrintString(List<OMNodeDetails> omList) {
printString.append("]");
return printString.toString();
}
+
+ public static String format(List<ServiceInfo> nodes, int port) {
Review Comment:
Instead of multiple fields like Current Role, leaderID , we can rather add
this info in this output itself, just add a logic like
```
public static String format(List<ServiceInfo> nodes,
int port, String leaderId) {
StringBuilder sb = new StringBuilder();
int count = 0;
for (ServiceInfo info : nodes) {
// Printing only the OM's running
String role =
info.getOmRoleInfo().getNodeId().equals(leaderId)?"LEADER":"FOLLOWER";
if (info.getNodeType() == HddsProtos.NodeType.OM) {
sb.append(
String.format(
" { HostName: %s | Node-Id: %s | Ratis-Port : %d | Role : %d
} ",
info.getHostname(),
info.getOmRoleInfo().getNodeId(),
port,
role
));
```
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java:
##########
@@ -267,6 +269,11 @@ public static boolean isReadOnly(
case ListTenant:
case TenantGetUserInfo:
case TenantListUser:
+ case RangerBGSync:
+ // RangerBGSync is a read operation in the sense that it doesn't directly
Review Comment:
Unrelated change
##########
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/ozoneManager.js:
##########
@@ -113,5 +113,12 @@
require: {
overview: "^overview"
},
+ controller: function ($http) {
+ var ctrl = this;
+ $http.get("jmx?qry=Ratis:service=RaftServer,group=*,id=*")
+ .then(function (result) {
Review Comment:
can remove this part if the above approach works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
