sodonnel commented on PR #3610: URL: https://github.com/apache/ozone/pull/3610#issuecomment-1190391540
> 1 UnderReplicatedProcessor and OverReplicatedProcessor now run in a single thread background service, can we add a thread pool to run these task concurrently? @JacksonYao287 Why do you think these need a thread pool? I have not tested yet, but I feel that a single thread processing each queue should be fast enough. In the future, we also plan to limit the amount of work to assign to DNs in a given period, and then I suspect a single thread per queue would be fast enough to handle the processing - certainly it should be able to allocate more commands to the DNs in a DN heartbeat interval than the DN could process. @umamaheswararao These changes look good - we could do with some unit test for OverReplicationProcessor, similar to those in TestUnderReplicatedProcessor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
