smengcl opened a new pull request, #3613:
URL: https://github.com/apache/ozone/pull/3613

   …ndException back to the caller in order for Recon to fall back to full 
snapshot
   
   ## What changes were proposed in this pull request?
   
   Recon expects an exception to be thrown in order to fall back to full 
snapshot when an OM DB delta update cannot be retrieved:
   
   
https://github.com/apache/ozone/blob/5ed0e0a9b4c8355f4cde064cc605bc419dacd9c3/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java#L456-L478
   
   However, the current logic implies that `RDBStore#getUpdatesSince` will 
never throw `SequenceNumberNotFoundException` back to the client (Recon) 
because it is caught as `IOException` in try-catch. [A patch 
earlier](https://github.com/apache/ozone/commit/5ed0e0a9b4c8355f4cde064cc605bc419dacd9c3#diff-fee5d70b574d804dcd62230fde7c8456690981673b18a9bc4b48c3fac3e945b8R322)
 unintentionally broke this intended behavior.
   
   The solution is to restore the intended behavior by explicitly catching 
`SequenceNumberNotFoundException` and throwing it back to the client.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-7032
   
   ## How was this patch tested?
   
   - [ ] Pending manual testing on a repro cluster.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to