neils-dev opened a new pull request, #3638: URL: https://github.com/apache/ozone/pull/3638
## What changes were proposed in this pull request? To improve description of error when _verify_ freon tests, `ockv`, are executed with default number-of-objects expected greater than the number of objects generated. Currently, the _**default**_ `number-of-tests` parameter is set to 1000. Under the condition that a freon test `generates` a number of objects less than the default and is followed by a verification freon test that `verifys` the objects _without_ specifying the number-of-tests, it fails with an error that is not descriptive of the cause. This patch fixes this error by adding 2 items to the console output of freon tests that make the error more obvious to the user: 1.) On start of freon command execution, in addition to outputting to the console the --prefix parameter used, _to also_ output the --number-of-tests parameter used (default or user specified). 2.) Should the command fail, as part of the print summary output to the console, to add the number-of-tests objects expected and the number succeeded. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-7066 ## How was this patch tested? Manually tested ockv command without --number-of-tests set when number of objects generated < default (1000 objects). _generate_ freon test, generate 10 keys with `ockg` `ozone freon ockg --volume=vol1 --bucket=freon --threads=12 --replication-type=RATIS --factor=THREE --size=134217728 --number-of-tests=10 --prefix=52128MYTEST` _Total execution time (sec): 35 Failures: 0 Successful executions: 10_ followed by a _verify_, validate freon test, validate keys _without_ specifying `--number-of-tests`, using default of 1000 with `ockv`: `ozone freon ockv --volume=vol1 --bucket=freon --threads=12 --prefix=52128MYTEST` 2022-07-28 17:00:10,322 [main] INFO impl.MetricsConfig: Loaded properties from hadoop-metrics2.properties 2022-07-28 17:00:10,393 [main] INFO impl.MetricsSystemImpl: Scheduled Metric snapshot period at 10 second(s). 2022-07-28 17:00:10,393 [main] INFO impl.MetricsSystemImpl: ozone-freon metrics system started **2022-07-28 17:00:10,493 [main] INFO freon.BaseFreonGenerator: Executing test with prefix 52128MYTEST and number-of-tests 1000** ... | 0/1000 Time: 0:00:022022-07-28 17:00:13,458 [pool-2-thread-12] ERROR freon.BaseFreonGenerator: Error on executing task 11 KEY_NOT_FOUND org.apache.hadoop.ozone.om.exceptions.OMException: Key:52128MYTEST/11 not found at org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolClientSideTranslatorPB.handleError(OzoneManagerProtocolClientSideTranslatorPB.java:696) ... 99.9% <= 5260.18 milliseconds Total execution time (sec): 9 Failures: 2 Successful executions: 10 **Expected 1000 --number-of-tests objects!**, successfully executed 10 CI workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
