kerneltime commented on code in PR #3554:
URL: https://github.com/apache/ozone/pull/3554#discussion_r934194822
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OmBucketReadWriteKeyOps.java:
##########
@@ -128,12 +128,10 @@ protected String createPath(String path) {
@Override
protected int getReadCount(int readCount, String readPath)
throws IOException {
- Iterator<? extends OzoneKey> ozoneKeyIterator = bucket.listKeys(
- OzoneConsts.OM_KEY_PREFIX + readPath + OzoneConsts.OM_KEY_PREFIX);
- while (ozoneKeyIterator.hasNext()) {
- ozoneKeyIterator.next();
- ++readCount;
- }
+ List<OzoneFileStatus> ozoneFileStatusList = bucket.listStatus(
+ OzoneConsts.OM_KEY_PREFIX + readPath + OzoneConsts.OM_KEY_PREFIX, true,
+ "/", keyCountForRead);
Review Comment:
Ideally the server should limit the max number of entries returned. This is
a CLI side change that should not be implementing such caps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
