kerneltime commented on code in PR #3651:
URL: https://github.com/apache/ozone/pull/3651#discussion_r940776988
##########
dev-support/ci/pr_title_check.sh:
##########
@@ -42,6 +42,8 @@ assertMatch '^HDDS-[1-9][0-9]{0,4}[^0-9]' 'Fail:
Jira must be 1 to 5 di
assertMatch '^HDDS-[1-9][0-9]{0,4}\.' 'Fail: missing dot after
Jira'
assertMatch '^HDDS-[1-9][0-9]{0,4}\. ' 'Fail: missing space after
Jira'
assertNotMatch '[[:space:]]$' 'Fail: trailing space'
+assertNotMatch '\.{3,}$' 'Fail: trailing ellipsis
indicates title is cut'
Review Comment:
Nit: Should this be length + trailing ellipsis? If not, the message can be
that trailing ellipsis is not permitted.
The length (72) is the main cause here as it has prescriptive titles for
commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
