xBis7 commented on code in PR #3309:
URL: https://github.com/apache/ozone/pull/3309#discussion_r943488483
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/NSSummary.java:
##########
@@ -93,7 +92,7 @@ public void setChildDir(Set<Long> childDir) {
}
public void setDirName(String dirName) {
- this.dirName = dirName;
+ this.dirName = removeTrailingSlashIfNeeded(dirName);
Review Comment:
> IIRC if the target is a directory (not a key), removing the trailing slash
might cause issue because of the key mismatch when getting value from RocksDB.
@smengcl This is the case for legacy, for FSO there is no difference. We
wanted to handle legacy the same way as FSO and that's why we are removing the
trailing slash. It's used by every test method, it's not making a difference. I
can remove it and include it in the next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
