adoroszlai commented on code in PR #3694:
URL: https://github.com/apache/ozone/pull/3694#discussion_r949874726


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/contract/AbstractContractUnbufferTest.java:
##########
@@ -54,6 +54,7 @@ public void setup() throws Exception {
   public void testUnbufferAfterRead() throws IOException {
     describe("unbuffer a file after a single read");
     try (FSDataInputStream stream = getFileSystem().open(file)) {
+      assertTrue(stream.hasCapability("in:unbuffer"));

Review Comment:
   `AbstractContractUnbufferTest` was copied from Hadoop when Ozone was still 
on 3.2.  I forgot to remove it  when upgrading to Hadoop 3.3.  This patch 
reminds me to do so.
   
   Therefore I think we should add this assertion in 
`hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java`
 instead.
   
   If you don't feel like updating the patch, I can make the move when removing 
this test class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to