umamaheswararao commented on code in PR #3645:
URL: https://github.com/apache/ozone/pull/3645#discussion_r950457779
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java:
##########
@@ -73,6 +73,20 @@ public ECUnderReplicationHandler(
this.nodeManager = nodeManager;
}
+ private boolean validatePlacement(List<DatanodeDetails> replicaNodes,
+ List<DatanodeDetails> selectedNodes) {
+ List<DatanodeDetails> nodes = new ArrayList<>(replicaNodes);
+ nodes.addAll(selectedNodes);
+ boolean placementStatus = containerPlacement
+ .validateContainerPlacement(nodes, nodes.size())
+ .isPolicySatisfied();
+ if (!placementStatus) {
+ LOG.warn("Selected Nodes does not satisfy placement policy: {} " +
Review Comment:
Typo: Nodes - nodes and please put a period before starting next sentence.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java:
##########
@@ -73,6 +73,20 @@ public ECUnderReplicationHandler(
this.nodeManager = nodeManager;
}
+ private boolean validatePlacement(List<DatanodeDetails> replicaNodes,
+ List<DatanodeDetails> selectedNodes) {
+ List<DatanodeDetails> nodes = new ArrayList<>(replicaNodes);
+ nodes.addAll(selectedNodes);
+ boolean placementStatus = containerPlacement
+ .validateContainerPlacement(nodes, nodes.size())
+ .isPolicySatisfied();
+ if (!placementStatus) {
+ LOG.warn("Selected Nodes does not satisfy placement policy: {} " +
Review Comment:
Are you missed to pass the params here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
