umamaheswararao commented on PR #3667: URL: https://github.com/apache/ozone/pull/3667#issuecomment-1222642747
> we could get into a position where we try reconstruction only to have a replica we are reading from removed by over-replication handling at the same time. I am not sure this patch added much complexity than what we have, but your pointed case is a good one to rethink on this patch. I agree this should be a corner case and this is possible only for smaller clusters. However we should fix this though as some test clusters can go into this situations and we should have some solution for it. I think delaying under replication is not a good idea. or should be check cluster size and over replications are at same size then only we return over replication first? I know this would introduce one more ugly check though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
