sodonnel commented on code in PR #3661:
URL: https://github.com/apache/ozone/pull/3661#discussion_r952436527
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/TestECContainerReplicaCount.java:
##########
@@ -229,7 +229,7 @@ public void testAdditionalMaintenanceCopiesAllMaintenance()
{
Collections.emptyList(), 1);
Assertions.assertFalse(rcnt.isSufficientlyReplicated(false));
Assertions.assertFalse(rcnt.isOverReplicated(true));
- Assertions.assertEquals(4, rcnt.additionalMaintenanceCopiesNeeded());
+ Assertions.assertEquals(4, rcnt.additionalMaintenanceCopiesNeeded(false));
Review Comment:
All the calls I can see in the this test calss call
`rcnt.additionalMaintenanceCopiesNeeded(false)` with `false`. We should add at
least one test with some pending add and test the `true` condition too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
