kerneltime commented on PR #3713: URL: https://github.com/apache/ozone/pull/3713#issuecomment-1226603629
> > > Should the logic to close the DB be moved inside `initializeNewRdbStore`? > > > > > > Thanks for the review, @kerneltime. I guess the closure of the existing DB should be in `updateOmDB(File newDbLocation)` as it's meant to replace the DB object. But I'm ok either way, think it can be better if `initializeNewRdbStore` only creates and initializes `DBStore` and doesn't attempt to `set`. > > I agree. It would be good to place the new DB, initialize it, and then make it available. Looking at the code, I am unsure what the concurrency requirements are here. Looks like It is single-threaded. For now, this is fine, so gave it a ship it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
