lokeshj1703 commented on code in PR #3701: URL: https://github.com/apache/ozone/pull/3701#discussion_r954601442
########## hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/storage/DiskBalancerConfiguration.java: ########## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdds.scm.storage; + +import org.apache.hadoop.hdds.conf.Config; +import org.apache.hadoop.hdds.conf.ConfigGroup; +import org.apache.hadoop.hdds.conf.ConfigTag; +import org.apache.hadoop.hdds.conf.ConfigType; +import org.apache.hadoop.hdds.conf.ConfigurationSource; +import org.apache.hadoop.hdds.protocol.proto.HddsProtos; +import org.jetbrains.annotations.NotNull; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * This class contains configuration values for the DiskBalancer. + */ +@ConfigGroup(prefix = "hdds.datanode.disk.balancer") +public final class DiskBalancerConfiguration { + private static final Logger LOG = + LoggerFactory.getLogger(DiskBalancerConfiguration.class); + + @Config(key = "volume.density.threshold", type = ConfigType.STRING, + defaultValue = "10", tags = {ConfigTag.DISKBALANCER}, + description = "Threshold is a percentage in the range of 0 to 100. A " + + "datanode is considered balanced if for each volume, the " + + "utilization of the volume(used space to capacity ratio) differs" + + " from the utilization of the datanode(used space to capacity ratio" + + " of the entire datanode) no more than the threshold.") + private String threshold = "10"; + + @Config(key = "max.disk.throughputInMBPerSec", type = ConfigType.LONG, + defaultValue = "10", tags = {ConfigTag.DISKBALANCER}, + description = "The max balance speed.") + private long diskBandwidth = 10; + + @Config(key = "parallel.thread", type = ConfigType.INT, + defaultValue = "5", tags = {ConfigTag.DISKBALANCER}, + description = "The max parallel balance thread count.") + private int parallelThread = 5; + + /** + * Gets the threshold value for DiskBalancer. + * + * @return percentage value in the range 0 to 100 + */ + public double getThreshold() { + return Double.parseDouble(threshold); + } + + public double getThresholdAsRatio() { + return Double.parseDouble(threshold) / 100; + } + + /** + * Sets the threshold value for Disk Balancer. + * + * @param threshold a percentage value in the range 0 to 100 + */ + public void setThreshold(double threshold) { + if (threshold < 0d || threshold >= 100d) { + throw new IllegalArgumentException( + "Threshold must be a percentage(double) in the range 0 to 100."); + } + this.threshold = String.valueOf(threshold); + } + + /** + * Gets the disk bandwidth value for Disk Balancer. + * + * @return max disk bandwidth per second + */ + public double getDiskBandwidth() { + return diskBandwidth; + } + + /** + * Sets the disk bandwidth value for Disk Balancer. + * + * @param diskBandwidth the bandwidth to control balance speed + */ + public void setDiskBandwidth(long diskBandwidth) { Review Comment: Is diskBandwidth in MB? Would it better to support string format as input? Maybe we should add "InMB" suffix to the function and input parameter to reflect that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
