Xushaohong commented on PR #3691: URL: https://github.com/apache/ozone/pull/3691#issuecomment-1230197700
> > Moving the DeletedBlocksTransaction to common hdds.proto is an ideal solution, > > but it will lead to the compatibility problem, so I adds the import of ScmServerDatanodeHeartbeatProtocol.proto > > I don't think we want this dependency chain. hdds.proto exists to prevent the admin and heartbeat proto from depending on each other. Cross client and rolling upgrade compatability (future work) will be harder to maintain with this dependency. The DeletedBlocksTransaction message is not very complicated. Could we make a different version of that message to be used in the client response placed in ScmAdminProtocol.proto? The problem mentioned is right, as the migration of proto would bring the compatibility issue, I just considered the reuse form. I have now added the `DeletedBlocksTransactionInfo` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
