kerneltime commented on code in PR #3728:
URL: https://github.com/apache/ozone/pull/3728#discussion_r959820591
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java:
##########
@@ -210,6 +210,13 @@ public Response put(
"Connection", "close").build();
}
+ // Normal put object
+ bucket = getBucket(bucketName);
+ Map<String, String> customMetadata =
+ getCustomMetadataFromHeaders(headers.getRequestHeaders());
Review Comment:
Filter the metadata here instead of filtering it in Key creation. Filtering
it in Key construction might have unintended consequences if the key is
supposed to have one of the reserved metadata keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
