adoroszlai commented on PR #3732: URL: https://github.com/apache/ozone/pull/3732#issuecomment-1238147715
> this is unpredictable that checkstyle fails doesn't fail whole build I think most developers run checkstyle via the script `hadoop-ozone/dev-support/checks/checkstyle.sh`, which fails on violation, and prints violations in a more useful way. We can change the default config, though, to cover the case where `mvn checkstyle:check` is run manually: https://github.com/apache/ozone/blob/3d3e9eaf00385f2d2b5050792e96092e07cc09d7/pom.xml#L2039 That should be fine, as `hadoop-ozone/dev-support/checks/checkstyle.sh` explicitly sets it: https://github.com/apache/ozone/blob/3d3e9eaf00385f2d2b5050792e96092e07cc09d7/hadoop-ozone/dev-support/checks/checkstyle.sh#L24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
