sodonnel commented on code in PR #3738:
URL: https://github.com/apache/ozone/pull/3738#discussion_r964595292
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java:
##########
@@ -248,6 +261,38 @@ public synchronized void stop() {
}
}
+ /**
+ * Create Replication Manager sub services such as Over and Under Replication
+ * processors.
+ */
+ private void createSubServices() {
Review Comment:
How about just making these other thread simple threads that we start with
runnables that use the RM.shouldRun() internally?
If we start finding a lot of this sort of things in the future, we can try
to make it generic, but for now perhaps its not worth it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
